Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP HJ-338 added sorting for system.privacy_declarations and a test to verify #5683

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP HJ-338 added sorting for system.privacy_declarations and a test to verify #5683

wants to merge 3 commits into from

Conversation

JadeCara
Copy link

@JadeCara JadeCara commented Jan 17, 2025 •
edited by jira bot
Loading

Closes #HJ-338

Description Of Changes

Added an order_by on name to the System.privacy_declarations model. Added a test to verify that the privacy declarations will be in alphabetical order.

Code Changes

  • Added order_by=PrivacyDeclaration.name to System model.
  • Added tests with new privacy declarations to verify they will return in the correct order.

Steps to Confirm

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 11:34pm

@cypress Cypress
Copy link

cypress bot commented Jan 17, 2025 •
edited
Loading

fides    Run #11845

Run Properties:  status check passed Passed #11845  •  git commit 9c0cc9b30b ℹ️: Merge 7713582824b8fd6b184e33c5c5f2e667cc801d59 into fdd8b4bcbaf910f4d5bc5b979d28...
Project fides
Branch Review refs/pull/5683/merge
Run status status check passed Passed #11845
Run duration 00m 49s
Commit git commit 9c0cc9b30b ℹ️: Merge 7713582824b8fd6b184e33c5c5f2e667cc801d59 into fdd8b4bcbaf910f4d5bc5b979d28...
Committer JadeWibbels
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (fdd8b4b) to head (7713582).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5683   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files         388      388           
  Lines       24033    24033           
  Branches     2594     2594           
=======================================
  Hits        20943    20943           
  Misses       2529     2529           
  Partials      561      561

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JadeCara